Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button): reduce the thickness of button outline #376

Merged
merged 2 commits into from
Oct 10, 2022
Merged

fix(button): reduce the thickness of button outline #376

merged 2 commits into from
Oct 10, 2022

Conversation

iamgideonidoko
Copy link
Contributor

Description

This PR reduces the thickness of the button outline when the outline prop is set to true.

Fixes #361

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change contains documentation update

Breaking changes

No breaking changes

How Has This Been Tested?

Manually (Visually)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@rluders
Copy link
Collaborator

rluders commented Oct 10, 2022

Hi @iamgideonidoko, thanks for the PR. It seems that you need to fix one small problem in your code to make the lint happy, and then I'll be happy to merge it.

@rluders rluders self-requested a review October 10, 2022 12:21
@iamgideonidoko
Copy link
Contributor Author

I've made the fix :).

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 98.61% // Head: 98.61% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9e83cdc) compared to base (6f6a63a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #376   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          89       89           
  Lines        4116     4120    +4     
  Branches      375      376    +1     
=======================================
+ Hits         4059     4063    +4     
  Misses         57       57
Impacted Files Coverage Δ
src/lib/components/Button/index.tsx 100.00% <100.00%> (ø)
src/lib/theme/default.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

rluders
rluders approved these changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@rluders rluders merged commit 5ef0aef into themesberg:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rluders rluders rluders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buttons outline does not match specification
2 participants
@iamgideonidoko @rluders